Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Update to anvil-zksync #253

Open
cpb8010 opened this issue Jan 12, 2025 · 0 comments
Open

[Request]: Update to anvil-zksync #253

cpb8010 opened this issue Jan 12, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@cpb8010
Copy link
Contributor

cpb8010 commented Jan 12, 2025

📝 Description

The current CI and test infra relies on validation behavior only found in the last stable release of era-test-node. Anvil-zksync changes the validation behavior so that transactions that fail validation don't get reported as reverted to the chai extension matchers. This causes many of the key tests to break that check for validation failures.

To upgrade we'd need to find a better way to check for failed validation other than just not being able to find a transaction after broadcast (which is what happens if you just upgrade without changing the tests, the tests fail).

🤔 Rationale

The new behavior should be more similar to how the validation failures behave in the public and testnet RPCs, so might help devs troubleshoot.

📋 Additional context

Updating the chai matcher to better reach into the transaction status is also an option.
It's also possible to fix this if we move from hardhat to foundry so we also have to migrate the chai matchers.

@cpb8010 cpb8010 added the enhancement New feature or request label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant