You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current CI and test infra relies on validation behavior only found in the last stable release of era-test-node. Anvil-zksync changes the validation behavior so that transactions that fail validation don't get reported as reverted to the chai extension matchers. This causes many of the key tests to break that check for validation failures.
To upgrade we'd need to find a better way to check for failed validation other than just not being able to find a transaction after broadcast (which is what happens if you just upgrade without changing the tests, the tests fail).
🤔 Rationale
The new behavior should be more similar to how the validation failures behave in the public and testnet RPCs, so might help devs troubleshoot.
📋 Additional context
Updating the chai matcher to better reach into the transaction status is also an option.
It's also possible to fix this if we move from hardhat to foundry so we also have to migrate the chai matchers.
The text was updated successfully, but these errors were encountered:
📝 Description
The current CI and test infra relies on validation behavior only found in the last stable release of era-test-node. Anvil-zksync changes the validation behavior so that transactions that fail validation don't get reported as reverted to the chai extension matchers. This causes many of the key tests to break that check for validation failures.
To upgrade we'd need to find a better way to check for failed validation other than just not being able to find a transaction after broadcast (which is what happens if you just upgrade without changing the tests, the tests fail).
🤔 Rationale
The new behavior should be more similar to how the validation failures behave in the public and testnet RPCs, so might help devs troubleshoot.
📋 Additional context
Updating the chai matcher to better reach into the transaction status is also an option.
It's also possible to fix this if we move from hardhat to foundry so we also have to migrate the chai matchers.
The text was updated successfully, but these errors were encountered: