Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our native module interfaces more 7579 like #82

Open
6 tasks
cpb8010 opened this issue Oct 7, 2024 · 0 comments
Open
6 tasks

Make our native module interfaces more 7579 like #82

cpb8010 opened this issue Oct 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request project: contracts

Comments

@cpb8010
Copy link
Contributor

cpb8010 commented Oct 7, 2024

So the current install process for modules split significantly as we worked on the interface for the native modules from the 7579 adapter. Now that we've moved past the clave validation interface there's a few things we want to clean up:

  • Use module type ids instead of lists during install (validators, hooks, callbacks, fallbacks)
  • Use isValidSignature instead of handleSignature for 1271 compliance
  • Use the same signature delegation for validateUserOp as we do in module validator to support multiple validation types
  • Re-connect execution hook storage (vs clave validation hook types)
  • Remove validation hook in favor of validation signature that includes the transaction data (allow using either/both isValidSignature and/or validateTransaction) depending on module.
  • Setup callback execution
@cpb8010 cpb8010 added the enhancement New feature or request label Oct 7, 2024
@cpb8010 cpb8010 self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request project: contracts
Projects
None yet
Development

No branches or pull requests

2 participants