Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request finalization status of withdrawal on the fetch params phase #193

Conversation

montekki
Copy link
Contributor

Previously the status of withdrawal whether it is finalized is not has only
been asked after unsuccessful finalization prediction from the smart contract.

However, if the finalizer has no money it will be stuck at a given height and
not request any other finalization statuses of withdrawals in the meanwhile.

This fix:

  1. Adds logic to immediately ask the finalization status on params fetch step
  2. Adds a migration to clear the table the finalization_data table can be cleared and statuses re-requested.

@montekki montekki merged commit 426bcd5 into main Sep 20, 2023
5 checks passed
@montekki montekki deleted the fs-continue-to-query-parameters-if-sending-a-transaction-has-failed branch September 20, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants