feat: collect withdrawal volumes metrics #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
montekki
commented
Sep 26, 2023
montekki
commented
- wip
- add method to query withdrawals
- adds metering of withdrawals values
Deniallugo
reviewed
Sep 27, 2023
Deniallugo
previously approved these changes
Sep 28, 2023
storage/src/lib.rs
Outdated
| " | ||
| SELECT * FROM | ||
| withdrawals | ||
| WHERE id in (SELECT * FROM unnest( $1 :: bigint[] )) |
There was a problem hiding this comment.
I think it's supposed to be select id from unnest( $1 :: bigint[]))
withdrawals-meterer/src/lib.rs
Outdated
Comment on lines
17
to
25
| lazy_static! { | ||
| static ref TOKEN_DECIMALS: Arc<RwLock<HashMap<Address, u32>>> = { | ||
| let mut map = HashMap::new(); | ||
| map.insert(ETH_TOKEN_ADDRESS, 18_u32); | ||
|
|
||
| Arc::new(RwLock::new(map)) | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Based on the number of tokens, seems it's better to create a struct WithdrawalsMeter with cache, pool and name inside and initialize it once in finalizer and once in watcher
montekki
commented
Sep 28, 2023
Deniallugo
reviewed
Sep 28, 2023
withdrawals-meterer/src/lib.rs
Outdated
| /// | ||
| /// * `pool`: DB connection pool | ||
| /// * `metric_name`: Name of the metric to meter to | ||
| pub fn new(pool: PgPool, metric_name: &'static str) -> Self { |
There was a problem hiding this comment.
I think it's better to have a component name and generate the metric name based on it, otherwise it's hard to add more metrics
Deniallugo
approved these changes
Sep 28, 2023
montekki
deleted the
fvs-pla-558-collect-same-withdrawal-amounts-metrics-as-old-finalizer
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.