Bug: Hidden side bar can't opened

[kamre]

Summary:
It is not possible to show the side bar when it was hidden with some active board.

Steps to reproduce the behavior:

1. Activate (select) some board
2. Click on hide side bar button
3. Button (hamburger) for showing the side bar is not visible

Expected behavior:
Button for showing the side bar should be visible.

Screenshots:

Platform:

• Browser and version: Chrome 91
• OS and version: Windows

Additional context:
This is a regression from 0.6.7 introduced in pull request #447 by setting z-index of .BoardComponent> .top-head inside webapp/src/components/centerPanel.scss to value 100 while z-index of hidden side bar is only 5.

[kamre]

Looks like duplicate of #567 that is fixed in main branch.

But assigning bigger and bigger z-index looks a bit suspicious. Is there a place where the usage of z-index for different UI elements is described?

[peteristhegreat]

Raising the z index does fix it!

.Sidebar.hidden {
    z-index: 101;
}

[chenilim]

@harshilsharma63, could you take a quick look at this and close it if the issue is indeed fixed in #567? Thanks.

[harshilsharma63]

@chenilim yes this is a duplicate.

@kamre can you try it out the latest main?

As long as we can ensure relative values of z-index stay in the right order it's completely fine.

[kamre]

@harshilsharma63 It works correctly on the latest main branch.

I propose to add a check for hide/show sidebar when there is an active board to Cypress test. What do you think about this?

[harshilsharma63]

@kamre yes we should definitely add a test for it since it's a primary functionality.

Would you be willing to add that test?