Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Build part is broken #206

Open
shurrman opened this issue Jan 25, 2022 · 1 comment
Open

Manual Build part is broken #206

shurrman opened this issue Jan 25, 2022 · 1 comment
Labels
Type/Bug Something isn't working

Comments

@shurrman
Copy link

  1. Clone the repo.
  2. Read the Readme, "Manuals Builds" part
  3. run ./docker-make
  4. get full buch of outdated warnings and eventually errors that break the build
    Seems like totally outdated, at least what is Node-related
@larkox larkox added the Triage label Feb 1, 2022
@hanzei hanzei added the Type/Bug Something isn't working label Feb 7, 2022
@VincentSC
Copy link

4 changes in Package.json are needed:

    "enzyme-adapter-react-16": "1.15.7",
    "eslint-import-resolver-webpack": "0.13.2",
    "eslint-plugin-import": "2.27.5",
    "html-webpack-plugin": "4.5.2",

The first three are to get the disappeared versions, and html-webpack-plugin was missing.

Dockerfile needs 2 changes:

FROM golang:latest

RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.51.1

Just bump to the latest, because it's just for building.

Result:

plugin built at: dist/jitsi-2.0.0.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants