Update Electron to 1.4.12 for Certificate Transparency Fix #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certificate Transparency Fix http://electron.atom.io/blog/2016/12/09/certificate-transparency-fix
|
Have been testing this today, no issues yet. Will continue tomorrow, |
|
Okay, no issues from my end. Propose that we merge this into the 3.5 branch, cut RC3 on Monday and I'll ask the Mattermost team help test it prior to our release on Wednesday. |
|
Okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
Electron 1.4.6 (1.4.0-1.4.11) has an issue where some HTTPS connection will start to fail after a certain date (January 14th, 2017 9:00 PM PST).
Issue link
http://electron.atom.io/blog/2016/12/09/certificate-transparency-fix
Test Cases
Set computer's clock and add https://symbeta.symantec.com/welcome/ as a team URL.
Additional Notes
Artifacts: https://circleci.com/gh/yuya-oc/desktop/110#artifacts