Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing "Return" in the "Switch Channels" dialog adds a newline to the text input box #511

Closed
3 tasks done
benreic opened this issue Apr 13, 2017 · 1 comment
Closed
3 tasks done

Comments

@benreic
Copy link

benreic commented Apr 13, 2017

I confirm (by marking "x" in the [ ] below):


Summary
Pressing "Return" in the "Switch Channels" dialog adds a newline to the text input box after you've switched channels.

*Steps to reproduce

  1. Open Mattermost Desktop
  2. Press Cmd+K to open the "Switch Channels" dialog.
  3. Start typing the name of a channel.
  4. When the desired channel is selected in the auto complete drop down, press "Return" to choose the channel.
  5. Now that the desired channel is selected, press "Return" again to commit the change and close the dialog.
  6. Notice that you are now in the desired channel and that the input area has a newline inserted with the cursor focused on the text input box.
  • Operating System: macOS Sierra 10.12.4
  • Mattermost Desktop App version: 3.6.0
  • Mattermost Server version: 3.7.3

Expected behavior
I should be in the desired channel with the cursor focused on an empty text box.

Observed behavior
I am in the desired channel with the cursor focused on a textbox that has a newline inserted.

Possible fixes
My guess is that the code that responds to the "Return" keypress that closes the "Switch Channels" dialog box is bubbling the event up and allowing the main window to respond to the keypress as well. The keypress event should be cancelled in the dialog.

@benreic benreic closed this as completed Apr 13, 2017
@benreic benreic reopened this Apr 13, 2017
@jasonblais
Copy link
Contributor

Thanks @benreic! This issue will be resolved in the next Mattermost desktop app version. We're estimating it to be available by end of April.

#426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants