Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables from "team" to "server" in source code #623

Closed
3 tasks done
yuya-oc opened this issue Oct 14, 2017 · 6 comments · Fixed by #2711
Closed
3 tasks done

Rename variables from "team" to "server" in source code #623

yuya-oc opened this issue Oct 14, 2017 · 6 comments · Fixed by #2711

Comments

@yuya-oc
Copy link
Contributor

yuya-oc commented Oct 14, 2017

I confirm (by marking "x" in the [ ] below):


Jira: https://mattermost.atlassian.net/browse/MM-14093

Summary
Rename variables from "team" to "server" in source code.
The name has been originally since there is no team side bar in webapp. In that time, the app need to handle "team" URL (https://SERVER/TEAM) to show multiple teams in the single window.
Now it's confusing so we need to rename for readability.

NOTE: There is a distinction between server and team, some of the code is actually talking about server when using team, however, the MM webapp actually has the concept of a team, so some uses of team in the code should stay as team. Please reach out if this is difficult to determine!

Possible fixes

  • Rename variables by searching.
  • Consider upgrading config.json schema version.
@yuya-oc yuya-oc added this to the v3.9.0 milestone Oct 14, 2017
@amyblais amyblais removed this from the v4.1.0 milestone Mar 21, 2018
@thepill
Copy link

thepill commented Jan 3, 2019

would like to do this as my first contribution and getting to know the project :)

@amyblais
Copy link
Member

Jira ticket for tracking: https://mattermost.atlassian.net/browse/MM-14093.

@amyblais amyblais changed the title Rename variables from "team" to "server" in source code [Help Wanted] Rename variables from "team" to "server" in source code Feb 27, 2019
@amyblais amyblais removed the Hackfest null label Mar 1, 2019
@amyblais amyblais added the Hacktoberfest null label Oct 7, 2019
@hanzei hanzei changed the title [Help Wanted] Rename variables from "team" to "server" in source code Rename variables from "team" to "server" in source code Oct 22, 2019
@amyblais amyblais removed the Hacktoberfest null label Nov 4, 2019
@deanwhillier
Copy link
Contributor

Updated the summary with an important note about server vs. team.

@jespino jespino added the Hacktoberfest null label Sep 21, 2020
@jespino jespino removed the Hacktoberfest null label Jan 14, 2021
@alphaninja27
Copy link

Copy the entire code on a text editor and then search for keywords, and change accordingly, or send me the code I shall do it for you.

@cpanato cpanato added the Hacktoberfest null label Oct 2, 2021
@devinbinnie devinbinnie removed the Hacktoberfest null label Dec 9, 2021
@HarikaGajjala221
Copy link

I would like to solve the issue

@devinbinnie
Copy link
Member

@harika551 Are you still planning on working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet