Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on a video attachment and then clicking on the icon (not the download link) of the attachment opens another Mattermost window #792

Closed
amyblais opened this issue May 8, 2018 · 6 comments

Comments

@amyblais
Copy link
Member

amyblais commented May 8, 2018

https://mattermost.atlassian.net/browse/MM-14163

Happens at least on Windows, 4.0.1 and 4.1.0-RC. Did not repro on webapp.

Steps to reproduce

  1. Upload and post a video attachment to a channel.
  2. Click the icon of the attachment (not the download button).

Expected behavior
Should not open a new window.

Observed behavior
A new Mattermost window is opened.

@amyblais amyblais changed the title Clicking on a video attachment and then clicking on the icon and not the download link of the attachment opens another Mattermost window Clicking on a video attachment and then clicking on the icon (not the download link) of the attachment opens another Mattermost window May 8, 2018
@jasonblais jasonblais added this to the v4.2.0 milestone May 22, 2018
@ylluminate
Copy link

I realize that this is not entirely related, but I wanted make note that video playback is missing video in macOS 10.13.6 when clicking the play button / image in a video preview within the client for videos such as YouTube videos. Audio plays, but no video.

Let me know if you'd like for me to generate a new issue or if this could be related to a 4.2 inbound update.

@yuya-oc
Copy link
Contributor

yuya-oc commented Jul 23, 2018

Hi @ylluminate, thanks for reporting. The issue is different thing, so would you create a new one? I feel the problem didn't reproduce for me, so probably you need to include more detailed information (please see the template which appears when you create a new issue)

@ylluminate
Copy link

Thanks @yuya-oc. I tried it in a web client on Chrome and got the same result so I've pushed this over to the -server Issues: mattermost/mattermost#9145

@weekscharlie
Copy link

I'd like to propose you target this issue for the 4.3.0 milestone. We've been waiting a while for the many great fixes already incorporated into 4.2.0 and a Priority 2 issue such as this one shouldn't delay the 4.2.0 release (IMO).

@yuya-oc yuya-oc modified the milestones: v4.2.0, v4.3.0 Nov 29, 2018
@amyblais
Copy link
Member Author

Jira ticket for tracking: https://mattermost.atlassian.net/browse/MM-14163

@esethna
Copy link
Contributor

esethna commented Feb 27, 2019

Hi @ylluminate, we haven't received an update so we'll assume that the problem is fixed or is no longer valid.

If you still experience the same problem, try upgrading to the latest version.

If the issue persists, reopen this issue with the relevant information and we'd be glad to help you where we can.

@esethna esethna closed this as completed Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants