Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean characters not processing properly on iOS #2286

Closed
avasconcelos114 opened this issue Oct 24, 2018 · 4 comments
Closed

Korean characters not processing properly on iOS #2286

avasconcelos114 opened this issue Oct 24, 2018 · 4 comments

Comments

@avasconcelos114
Copy link

Summary

When typing Korean, characters do not properly form syllables if the user tries to re-edit the middle of a sentence.

Environment Information

  • Device Name: iPhone 6s
  • OS Version: iOS 12
  • Mattermost App Version: 1.13.1 (Build 151)
  • Mattermost Server Version: 5.4.0

Steps to reproduce

  1. With a Korean keyboard enabled, type 테스트 ( + + + + + ) in the post textbox of any channel
  2. Manually drag the caret (text cursor) to the middle of the word
  3. Re-type the same word as step 1 (테스트)
  4. Text seen in input box is now 테스ㅌㅔㅅㅡㅌㅡ 트

Expected behavior

User should be able to freely add test in the middle of words

Observed behavior

Any Korean characters typed that aren't at the very end of the textbox aren't processed correctly
ios_korean_character

Possible fixes

It feels like when placing the caret in the middle, each keyboard press triggers the handleTextChange function and immediately sets a new value for the textbox, without giving the chance for users to complete the syllable.

@avasconcelos114
Copy link
Author

For reference, the way Korean writing works is that several characters bundles together to form a syllable, instead of being written individually as seen with the alphabet. So a syllable must be written by pressing + + (they're ordered from top to bottom, left to right).

The issue here happens when words in the middle are not being processed into syllables

@amyblais
Copy link
Member

Thank you @avasconcelos114, I'll test this out today.

One of our developers said that this might also be an issue on the React Native side, so we'll see if we open an Issue on their repo as well.

@amyblais
Copy link
Member

@avasconcelos114 I opened a bug ticket here: https://mattermost.atlassian.net/browse/MM-12813.

@amyblais
Copy link
Member

Hi @avasconcelos114,

Letting you know that this is an RN issue and there is a bug report on their repo here: facebook/react-native#19313.

I'll close this Issue here for now,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants