Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tooltip content for more types of GitHub links #604

Open
mickmister opened this issue Nov 15, 2022 · 10 comments
Open

Implement tooltip content for more types of GitHub links #604

mickmister opened this issue Nov 15, 2022 · 10 comments
Assignees
Labels
Difficulty/1:Easy Easy ticket Tech/ReactJS Tech/TypeScript Type/Enhancement New feature or improvement of existing feature

Comments

@mickmister
Copy link
Contributor

At the moment, we show a tooltip for issues and PRs. We can also show the tooltip for the following entities:

  • repos
  • branches
  • commits
  • files

The task here is to modify the Link Tooltip component to support showing a tooltip card for the entities listed above.

image

@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Hacktoberfest Good First Issue Suitable for first-time contributors Tech/ReactJS Difficulty/1:Easy Easy ticket Type/Enhancement New feature or improvement of existing feature Tech/TypeScript labels Nov 15, 2022
@Nityanand13
Copy link
Contributor

@mickmister What should we show in the tooltip for branches and files ?

@Nityanand13
Copy link
Contributor

@mickmister What is your suggestion for repos and commits?
As of now for repos we have added:

  • Description
  • Stars
  • Watching
  • Forks
  • Branches
  • Tags

TooltipForRepo

and for commit we have added:

  • Message

TooltipForCommit

@hanzei
Copy link
Contributor

hanzei commented Jan 3, 2023

@matthewbirtch What do you think?

@mickmister mickmister removed Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers labels Jan 3, 2023
@mickmister
Copy link
Contributor Author

@Nityanand13 For the repo view, I'm thinking a small preview of the README would be more beneficial than seeing the stats.

@mickmister What should we show in the tooltip for branches and files ?

I think the branch view can be the same as repo view. The file view could have a small preview of the first few lines of a file.

@Nityanand13
Copy link
Contributor

@mickmister For the repo, a small preview of README is enough or can we add stats along with that?

@Nityanand13
Copy link
Contributor

@mickmister Is there any modification needed for the tooltip of a file?

fileTooltip

@matthewbirtch
Copy link

matthewbirtch commented Jan 6, 2023

@matthewbirtch What do you think?

The suggestions here are decent suggestions. Should we queue this up for someone on the UX team to design something for each of these scenarios outlined before implementing or opening up for Help wanted? I know we don't have a truly dedicated UX designer for the integrations team right now, but I'm sure we can get someone to work on it.

@mickmister
Copy link
Contributor Author

Should we queue this up for someone on the UX team to design something for each of these scenarios outlined before implementing or opening up for Help wanted?

@matthewbirtch That sounds good to me 👍 How do you suggest I do this? Should I file a ticket in Jira, and assign to UX with fix version triage?

The file view could have a small preview of the first few lines of a file.

Note that if it's a permalink URL to a specific line/range of lines, the preview should keep those lines in mind

@matthewbirtch
Copy link

matthewbirtch commented Jan 9, 2023

@matthewbirtch That sounds good to me 👍 How do you suggest I do this? Should I file a ticket in Jira, and assign to UX with fix version triage?

That is fine @mickmister and we can triage it from there. FYI, we will likely be changing this process in the future, to keep it on the team that will be implementing with a ux-needed label and PMs can prioritize with UX, but for now, we can triage it easiest the way you've mentioned above.

@mickmister mickmister removed Hacktoberfest Good First Issue Suitable for first-time contributors labels Jan 24, 2023
@mkdbns mkdbns moved this from Todo to Pending Feedback in Brightscout Plugin Maintenance May 30, 2023
@mkdbns mkdbns moved this from Pending Feedback to In Progress in Brightscout Plugin Maintenance Jun 12, 2023
@raghavaggarwal2308
Copy link
Contributor

@wiggin77 Do you think we should start working on this issue or make this as help wanted. As this is quite a big task. We have to support multiple types of tooltips.
I have shared you the figma link for designs in your DM on hub.

@raghavaggarwal2308 raghavaggarwal2308 self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Tech/ReactJS Tech/TypeScript Type/Enhancement New feature or improvement of existing feature
Projects
Development

No branches or pull requests

5 participants