-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tooltip content for more types of GitHub links #604
Comments
@mickmister What should we show in the tooltip for |
@mickmister What is your suggestion for repos and commits?
and for commit we have added:
|
@matthewbirtch What do you think? |
@Nityanand13 For the repo view, I'm thinking a small preview of the README would be more beneficial than seeing the stats.
I think the branch view can be the same as repo view. The file view could have a small preview of the first few lines of a file. |
@mickmister For the repo, a small preview of README is enough or can we add stats along with that? |
@mickmister Is there any modification needed for the tooltip of a file? |
The suggestions here are decent suggestions. Should we queue this up for someone on the UX team to design something for each of these scenarios outlined before implementing or opening up for Help wanted? I know we don't have a truly dedicated UX designer for the integrations team right now, but I'm sure we can get someone to work on it. |
@matthewbirtch That sounds good to me 👍 How do you suggest I do this? Should I file a ticket in Jira, and assign to UX with fix version triage?
Note that if it's a permalink URL to a specific line/range of lines, the preview should keep those lines in mind |
That is fine @mickmister and we can triage it from there. FYI, we will likely be changing this process in the future, to keep it on the team that will be implementing with a |
@wiggin77 Do you think we should start working on this issue or make this as help wanted. As this is quite a big task. We have to support multiple types of tooltips. |
At the moment, we show a tooltip for issues and PRs. We can also show the tooltip for the following entities:
The task here is to modify the Link Tooltip component to support showing a tooltip card for the entities listed above.
The text was updated successfully, but these errors were encountered: