Store S3 bucket secret in KV store #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
changed the title
mickmister
commented
Jun 11, 2024
fmartingr
reviewed
Jun 26, 2024
| github.com/mattermost/mattermost-server/v6 v6.0.0-20221012175353-8cb6718a9bcc | ||
| github.com/mattermost/mattermost/server/public v0.0.9 | ||
| github.com/mattermost/mattermost/server/public v0.1.4 | ||
| github.com/mattermost/mattermost/server/v8 v8.0.0-20240610152044-b86ba51efd4f |
There was a problem hiding this comment.
Flagging this from our conversation yesterday. @wiggin77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it so when the admin submits the custom S3 bucket settings, we store it in the KV store, and store a string of asterisks in the server config. This is so we never expose the saved secret to the client later.
This PR also requires upgrading the MM server dependency. ATM this PR sets it to a very recent version, though it only needs to be up to 8.0 for the
ConfigurationWillBeSavedhook.Ticket Link
Fixes #54