Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLP-time implementation: language normalization #75

Merged
merged 7 commits into from
Mar 2, 2016

Conversation

kengz
Copy link
Contributor

@kengz kengz commented Mar 1, 2016

This is first of the series of coming NLP-based improvements. This implements a basic normalization module to process string tokens, and map them onto canonical words aka 'lemma', before parsing.

I've added lodash as a requirement. You may wish to add it when publishing the demo site too.
There's a list of Issues under work to keep track of next issues to fix. You may wish to update the changelog beneath after approving pr.

Issues fixed: #66, #64, #28, #16, #15, #11, #4

@kengz
Copy link
Contributor Author

kengz commented Mar 2, 2016

Nodejs v0.6 build fails. I've made it to search for any latest available lodash via npm. Can you take a quick look?

@matthewmueller
Copy link
Owner

all i have to say is WOW. This is why we open source projects :-D.

We can probably just remove node 0.6 support, but I'll take a look.

@kengz
Copy link
Contributor Author

kengz commented Mar 2, 2016

Haha exactly why I'm working from this repo too cuz it's MIT.

lodash isn't supported on nodejs earlier than 0.8, here. In fact the official page under Support says Node.js 0.10, 0.12, 4, & 5.

Do you wish to allow for these 4 versions only? Since I doubt that many people use 0.6, 0.8. Let me know if you'd like me to just change the travis.yml

Anyway on rereading your source code it has about 1/3 of the theorem implemented, I'll implement with some pre and post processing and it shall be complete. Then it will be perhaps the most dope time parser out there that is also mathematically proven to be complete.

@matthewmueller matthewmueller merged commit 1473aaf into matthewmueller:master Mar 2, 2016
@kengz
Copy link
Contributor Author

kengz commented Mar 2, 2016

@matthewmueller thanks for the merge. I'll continue to dev the next 2 phases. Once all is done we can close the open issues.

@matthewmueller
Copy link
Owner

Love it, I've opened up a separate PR to remove the lodash methods, but feel free to use them in your work, unless you can easily avoid it. I'll go through and see if I can remove them later :-)

@matthewmueller
Copy link
Owner

okay the website has been updated with your changes. looking forward to the next set of updates :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"an hour later", "half an hour later" seem not working
2 participants