Ruby 3 support #93
Closed
Ruby 3 support #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeepers
approved these changes
Apr 12, 2022
|
It probably won't be merged soon: #88 (comment) |
|
Thanks for doing this! Maybe we should make this against https://github.com/memoist/memoist ? Or possibly @sebjacobs would be able to approve this? |
|
@evanbattaglia moved to memoist#2 |
|
FYI: Added this alert to the new repo Important RecommendationConsider using MemoWise instead, as it is maintained, fully tested, provides thread safety guarantees, and is much, much faster. Other AlternativesIn case you need a tool with this feature set that is currently maintained, check out: Tip Seriously though, read the important note above. Warning If you must continue - be aware that this is unmaintained software. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken the changes from #92 fixed up the code and added tests and CI runs for Ruby 3 and 3.1
The solution for ruby3 kwargs is to add the hash of passed kwargs in its array form the the cache ivar.