Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #381

Closed
fladi opened this issue Jul 16, 2016 · 12 comments
Closed

New release? #381

fladi opened this issue Jul 16, 2016 · 12 comments
Labels

Comments

@fladi
Copy link
Contributor

fladi commented Jul 16, 2016

I would like to provide an official Debian package of django-imagekit. Is there a chance to get a new release sometime before november, because thats when the packages for the next stable Debian release will be frozen.

@vstoykov
Copy link
Collaborator

I was planning for a release soon because Django 1.10 is also coming (August) and will be better if there is a released version of django-imagekit which will support it.

There are few (possibly only one) bugs which I think are blockers for new version especially if it will go in official Debian repositories. I'm talking for #350 and #369. I was unable to create a test reproducing the issue in order to make a reliable fix for it.

If you can help with this I will be very glad.

@nicolasgrasset
Copy link

Hey!

Looks like @beshrkayali has a fix for #388. Should they/you/I open a PR?
develop...FundedByMe:develop

@vstoykov
Copy link
Collaborator

I'll be glad if they opened a PR because they are made the patch

@cedriccarrard
Copy link

@vstoykov Hey, when the release 3.4 is planned ? Have you need help for issue ?

@beshrkayali
Copy link

beshrkayali commented Dec 8, 2016

Hi guys! Sorry i just noticed this. Unfortunately I don't remember exactly what/why I did what (it's been a while) I did but feel free to open a pr with whatever I have that works (no need for attribution).

@Proper-Job
Copy link
Contributor

Proper-Job commented Feb 7, 2017

@vstoykov Is there still something blocking the 3.4 release?

@max-pfeiffer
Copy link

+1 here: it would be nice to have a packaged release with the Django 1.10 fixes.

@vstoykov
Copy link
Collaborator

Hello Guys. Sorry for the long time where there is no new ImageKit version. Especially I'm so sorry for missed opportunity ImageKit to be packaged in Debian.

Now some of the issues that I wanted to figure out was related to 3th party storages which does not support reopening of closed file (django-s3-storage added such a feature but in django-storages there is no such thing).

This should not block release of the new version.

I wanted to ask you guys for opinion what should be the next version 3.4 or 4.0. In develop there are changes which will drop compatibility with Django < 1.4 (Yeah I know that even 1.4 is EOL but ImageKit works with it and will not make trouble for people which are upgrading old projects to new Django version).

Is it more appropriate to bump major version number?

P.S. Actually ImageKit will work with Django 1.11 too ;)

@Proper-Job
Copy link
Contributor

@vstoykov in my opinion, if it introduces breaking changes for some people a 4.0 release is merited.
Thank you and greetings :)

@max-pfeiffer
Copy link

@vstoykov : same opinion here, thanks a lot!

@vstoykov
Copy link
Collaborator

@fellowshipofone For what I see about @beshrkayali work that you posted it is before issue #388 and also is in ImageKit tree. Probably they are unrelated.

@vstoykov
Copy link
Collaborator

There is now new ImageKit version 4.0 on PyPi https://pypi.python.org/pypi/django-imagekit/4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants