Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name changes and 404 in Three.js #16

Open
bambax opened this issue Dec 22, 2022 · 2 comments
Open

Name changes and 404 in Three.js #16

bambax opened this issue Dec 22, 2022 · 2 comments

Comments

@bambax
Copy link

bambax commented Dec 22, 2022

The demos that rely on Three.js don't work because

  • some ressources generate a 404 Not Found error (https://threejs.org/examples/js/controls/OrbitControls.js) which result in errors like Uncaught TypeError: THREE.OrbitControls is not a constructor
  • some classes and function have changed names (THREE.PlaneBufferGeometry has been renamed to THREE.PlaneGeometry.)

Maybe this can be solved easily by adding the correct version of Three.js in the repository instead of hot loading it from threejs.org.
@cactrot
Copy link

cactrot commented Dec 25, 2022 •
edited
Loading

Updated the imports and made a pull request (#17).

Tested to work on a local web server.

@lucas-schuermann lucas-schuermann mentioned this issue Dec 27, 2022
Closed
@lucas-schuermann
Copy link

Fixed for all TenMinutePhysics demos by #18. Hopefully it will get merged shortly. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bambax @lucas-schuermann @cactrot