Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: do everything in one go #2

Open
lig opened this issue Feb 13, 2018 · 2 comments
Open

Proposal: do everything in one go #2

lig opened this issue Feb 13, 2018 · 2 comments

Comments

@lig
Copy link

lig commented Feb 13, 2018

It looks like html-sanitizer does a lot of wibbly-wobbly things to produce the result.

It seems possible to implement every html-sanitizer feature using a smart plugin system for a custom SAX parser rules realization.

@lig
Copy link
Author

lig commented Feb 13, 2018

I'm going to come back here and implement this when I have enough time.

@matthiask
Copy link
Owner

Yes, this should be possible. The core of the cleaner is now more than 8 years old, so I probably would do it differently too these days :-)
feincms/feincms@0ec8e83

Luckily we have a testsuite now to catch regressions. However, it is not very exhaustive yet, so maybe it would also be good to expand the testsuite before moving to big refactorings. (No must-have at all, but would certainly make reviewing eventual pull requests easier!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants