Skip to content

Commit

Permalink
Rollup merge of rust-lang#111607 - jyn514:clubby-reviews, r=clubby789
Browse files Browse the repository at this point in the history
Add clubby789 to the bootstrap review rotation

r? `@clubby789` - thank you for volunteering!

I have been meaning for a very long time now to write up how to do reviews, but I haven't gotten around to it yet :( here is a short summary:

1. If you're not sure what the changes does or if it's ok, always feel free to ping someone else on the team, especially in the first few weeks. You can use `r? bootstrap` to get triagebot to assign someone else.
2. Bootstrap unfortunately has very few tests. Things that touch CLI or toml parsing should likely have a test in `src/bootstrap/config/tests.rs`; things that touch "core" build logic should have a test in `builder/tests.rs`, anything else kinda just slips in :( see rust-lang#102563 for ideas on how to improve the situation here.
3. "Major" changes should be documented in `src/bootstrap/CHANGELOG.md`. "Major" is up to you, but if it breaks a config option or otherwise is likely to break *someone's* build, it's probably major. If it breaks nearly *everyone*'s build, it should also update `VERSION` in `lib.rs`; this should be very rare. Please also ping me or Mark-Simulacrum for major changes (I might set up a triagebot ping for this so you don't have to remember).
4. Once you've approved the PR, tell bors it's ok - you've been contributing for a while so you know how bors works, but here's a cheatsheet just in case: https://bors.rust-lang.org

Documentation about how to use bootstrap lives at https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html; internal docs live in `src/bootstrap/README.md`. The latter unfortunately is not very complete.
  • Loading branch information
matthiaskrgr authored May 15, 2023
2 parents a91f879 + 29a81f5 commit 63315ca
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions triagebot.toml
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,7 @@ bootstrap = [
"@Mark-Simulacrum",
"@albertlarsan68",
"@ozkanonur",
"@clubby789",
]
infra-ci = [
"@Mark-Simulacrum",
Expand Down

0 comments on commit 63315ca

Please sign in to comment.