Skip to content

Commit

Permalink
Rollup merge of rust-lang#128640 - RalfJung:rwlock-macos-miri, r=joboet
Browse files Browse the repository at this point in the history
rwlock: disable 'frob' test in Miri on macOS

Due to rust-lang#121950, Miri will sometimes complain about this test on macOS. Better disable the test, as otherwise it can fail for unrelated PRs.

r? `@joboet`
  • Loading branch information
matthiaskrgr authored Aug 8, 2024
2 parents 3e9bd8b + a120fb7 commit d7e5622
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions library/std/src/sync/rwlock/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ fn smoke() {
}

#[test]
// FIXME: On macOS we use a provenance-incorrect implementation and Miri
// catches that issue with a chance of around 1/1000.
// See <https://github.com/rust-lang/rust/issues/121950> for details.
#[cfg_attr(all(miri, target_os = "macos"), ignore)]
fn frob() {
const N: u32 = 10;
const M: usize = if cfg!(miri) { 100 } else { 1000 };
Expand Down

0 comments on commit d7e5622

Please sign in to comment.