fix(tooltip): prevent infinite loop error when positioning tooltip

Fixes #1046
mattlewis92 · Aug 18, 2019 · cd2cd5a · cd2cd5a
1 parent ca3220b
commit cd2cd5a
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/projects/angular-calendar/src/modules/common/calendar-tooltip.directive.ts b/projects/angular-calendar/src/modules/common/calendar-tooltip.directive.ts
@@ -150,7 +150,7 @@ export class CalendarTooltipDirective implements OnDestroy, OnChanges {
     this.cancelTooltipDelay$.next();
   }
 
-  private positionTooltip(previousPosition?: string): void {
+  private positionTooltip(previousPositions: string[] = []): void {
     if (this.tooltipRef) {
       this.tooltipRef.changeDetectorRef.detectChanges();
       this.tooltipRef.instance.placement = positionElements(
@@ -160,8 +160,13 @@ export class CalendarTooltipDirective implements OnDestroy, OnChanges {
         this.appendToBody
       );
       // keep re-positioning the tooltip until the arrow position doesn't make a difference
-      if (previousPosition !== this.tooltipRef.instance.placement) {
-        this.positionTooltip(this.tooltipRef.instance.placement);
+      if (
+        previousPositions.indexOf(this.tooltipRef.instance.placement) === -1
+      ) {
+        this.positionTooltip([
+          ...previousPositions,
+          this.tooltipRef.instance.placement
+        ]);
       }
     }
   }