Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop on same day does not update time in custom title formatter #1238

Closed
tim-faase opened this issue Apr 22, 2020 · 8 comments
Closed
Labels

Comments

@tim-faase
Copy link

Describe the bug

Dragging an event on week view within the same day does not update the time shown in custom title formatter.

Minimal reproduction of the problem with instructions

https://stackblitz.com/edit/angular-wm4ozr

Screenshots

Edit Schedule _ DASH - Testing

Versions

  • @angular/core: 9.1.1
  • angular-calendar: 0.28.8
  • Browser name and version: Version 81.0.4044.122 (Official Build) (64-bit)
@matts-bot
Copy link

matts-bot bot commented Apr 22, 2020

Thanks so much for opening an issue! If you'd like me to give priority to answering your issue or would just like to support this project, then please consider sponsoring me

@mattlewis92
Copy link
Owner

Hey, thanks for reporting! I'm kind of amazed this has never come up before, I will do my best to find a way of fixing it 😄

@mattlewis92
Copy link
Owner

Please can you give 0.28.13 a go, it should be fixed now, thanks for reporting! 😄

@tim-faase
Copy link
Author

tim-faase commented May 4, 2020

Thank you matt! It took me a few hours to find the cause, our app wasn't working but Stackblitz example did, this fix works with snapDraggedEvents property set to true, with it set to false it doesn't work I'm afraid.
Appreciate all your work on this open source component.

@mattlewis92
Copy link
Owner

Ahh I didn't consider that, it's because the drag and drop library uses cloneNode on the element so it won't be updated while dragging, I think I can fix it pretty easily

@mattlewis92
Copy link
Owner

Please give 0.28.15 a go, it should be fixed now 😄

@tim-faase
Copy link
Author

tim-faase commented Jun 17, 2020

If you weren't so nice I might not be posting this! 😄 it has occurred to me twice; that a mismatch of @angular/core to your latest release causes drag and drop to stop working in --prod. ng serve is fine but once I build it to production with the flag the cells don't accept an eternal event.

@mattlewis92
Copy link
Owner

If you weren't so nice I might not be posting this! 😄 it has occurred to me twice; that a mismatch of @angular/core to your latest release causes drag and drop to stop working in --prod. ng serve is fine but once I build it to production with the flag the cells don't accept an eternal event.

Sounds more like a bug with angular itself rather than anything this library is doing, but if you can make a minimal repro on github that shows the problem then I can investigate further. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants