Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package libs as ES module to avoid warnings from Angular cli #1331

Closed
wants to merge 2 commits into from
Closed

Package libs as ES module to avoid warnings from Angular cli #1331

wants to merge 2 commits into from

Conversation

santam85
Copy link
Contributor

@santam85 santam85 commented Sep 8, 2020

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1331 into 0.29.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.29.0    #1331   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          39       39           
  Lines         784      784           
  Branches      139      139           
=======================================
  Hits          752      752           
  Misses          1        1           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc15e03...5e595ba. Read the comment docs.

@santam85
Copy link
Contributor Author

santam85 commented Sep 9, 2020

@mattlewis92 Would this be more likely to be released faster if we merged it to master instead?

@mattlewis92
Copy link
Owner

Hey @santam85, thanks for taking the time to make this PR! I managed to find a way to make the date adapters in es module format, whilst preserving the commonjs format for anyone that was relying on it so that it won't be breaking. I just released 0.28.17 with the fix, please let me know if that works for you and sorry again about taking so long to get to this! 🙌

@santam85 santam85 deleted the 0.29.0 branch September 12, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants