Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event (eventClicked) is not fired in mobile for draggable events #203

Closed
theunreal opened this issue May 11, 2017 · 9 comments
Closed

Event (eventClicked) is not fired in mobile for draggable events #203

theunreal opened this issue May 11, 2017 · 9 comments
Labels

Comments

@theunreal
Copy link

Bug description / Feature request:

Event click event not working in mobile

For bugs only, a link to minimally working plunker that reproduces the issue (you can fork a starter from any of the demos)

All events with property draggable set to true are not executing the (eventClicked) event.

Versions

Angular: 4

Calendar library: 0.14.0

Browser name and version: Chrome

@theunreal theunreal changed the title Event click event not working in mobile Event (eventClicked) is not fired in mobile for draggable May 11, 2017
@theunreal theunreal changed the title Event (eventClicked) is not fired in mobile for draggable Event (eventClicked) is not fired in mobile for draggable events May 11, 2017
@mattlewis92
Copy link
Owner

I can reproduce, thanks for reporting, will get it fixed up soon 😄 (in the meantime I wonder if adding fastclick to your project fixes the issue?)

@theunreal
Copy link
Author

theunreal commented May 11, 2017

@mattlewis92 I will check and update, btw I didn't dive into the library but I wonder if it's worth trying to use HammerJS (tap) instead of (click) if you actaully used (click).

@mattlewis92
Copy link
Owner

I know angular has some built in support for hammerjs but I'm not 100% sure how it'd work for libraries as I wouldn't want to add a dependency on hammerjs for all users of this lib. I'll do some digging and see what I can come up with.

@mattlewis92
Copy link
Owner

Gave this some more thought and I've solved it by creating a custom click directive that uses hammerjs's tap event and falls back to click if hammer is not loaded. Does this work for you?

@adammedford
Copy link

I'm actually having this same issue, but on desktop in Chrome.

'eventTimesChanged' fires on clicking draggable events in all views. The only way I've managed to get eventClicked to work when both are present is to double click the event, but even that is inconsistent and still attempts to reschedule the event first.

@mattlewis92
Copy link
Owner

@adammedford I'm not able to reproduce your issue, can you see the same problem on any of the demos?

@adammedford
Copy link

I've not been able to reproduce it outside of my own code; although my code is basically a patchwork of different demos. Seems likely its being caused by something external but if I can track it down I will let you know. Thanks for the prompt response.

@AbhiTiwari1289
Copy link

AbhiTiwari1289 commented Nov 29, 2017

Bug
1- Open Kitchen-sink demo in chrome browser
2- Select day view
3- Select Mobile mode from inspect or Ctrl+Shift+M
4- Click on the draggable event
You will notice that the eventClicked is not firing, only eventTimesChanged fires.

@realshadow
Copy link

I have the same problem, it happens in Safari and Firefox as well so I dont think its browser related. What happens in my case is that eventTimesChanged is always fired, even on click. I solved it by checking diff in minutes between new and old date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants