Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an event meta / data property to the CalendarEvent interface #218

Closed
mattlewis92 opened this issue May 29, 2017 · 5 comments
Closed

Comments

@mattlewis92
Copy link
Owner

This is probably a nicer api than extending the CalendarEvent interface and prevents users accidentally polluting future possible event properties.

@etwillbefine
Copy link
Collaborator

I know its a hard breaking-change and maybe even not a better API but wouldn't it be better to make the calendar event (meta property) generic? When I extend the CalendarEvent interface I still have typings but using the new meta attribute makes it harder. So imo, the new API to prevent users accidentally polluting event properties is not worth losing typings?! :/

@mattlewis92
Copy link
Owner Author

Ohh good idea, I've not released this yet so it wouldn't be a breaking change

@mattlewis92
Copy link
Owner Author

That was easier than I expected 😄 mattlewis92/calendar-utils@7821b04

@etwillbefine
Copy link
Collaborator

I did not know something like this is possible mattlewis92/calendar-utils@7821b04#diff-fdb1138e6fb46aad8352fc0cbfb32a0eR49
No BC, you're right :D (thought so because TS compiler will fail for generic classes without typing, but here comes the default awesome!)

@mattlewis92
Copy link
Owner Author

I didn't know it was possible, I just tried sticking it in and the compiler didn't complain 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants