Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong inflection of month names in polish #757

Closed
jaruszewskiG opened this issue Sep 27, 2018 · 5 comments
Closed

Wrong inflection of month names in polish #757

jaruszewskiG opened this issue Sep 27, 2018 · 5 comments

Comments

@jaruszewskiG
Copy link

jaruszewskiG commented Sep 27, 2018

Describe the bug

The translation of months to polish doesn't seem to work properly. It changes the inflection of the word needlessly. I'm doing everything, just like in this example

For example:

"January" is translated to "stycznia" instead of "styczeń"
"February" is translated to "lutego" instead of "luty"
etc... all months have wrong inflection.

Versions

  • @angular/core: 6.0.3
  • angular-calendar: 0.25.2
  • Browser name and version: 69.0.3497.100
@jaruszewskiG jaruszewskiG changed the title Wrong inflection of months in polish Wrong inflection of month names in polish Sep 27, 2018
@mattlewis92
Copy link
Owner

Thanks for reporting this! I think I have a fix, but could you tell me, is it just the month view title that's wrong? Is the day view title correct? e.g. is Saturday, January 27, 2018 -> sobota, stycznia 27, 2018 correct?

@jaruszewskiG
Copy link
Author

Hi, thanks for quick reply. Yes, only the months are wrong. I've changed
{{ viewDate | calendarDate:(view + 'ViewTitle'): locale }}
to
{{ viewDate | calendarDate:('day' + 'ViewTitle'): locale }}
and it looks exactly as you've written in your example: sobota, stycznia 27, 2018

@no-response no-response bot removed the needs reply label Sep 28, 2018
@Shumatsu
Copy link

Month - Day - Year format isn't really used in Polish language. Day - Month - Year is the most used format.

@mattlewis92
Copy link
Owner

This should be fixed now in 0.26.2, please let me know if I missed off any other places 😄

@jaruszewskiG
Copy link
Author

Hi, it works fine now! :) I had some problems with upgrading to 0.26.3, because I'm using custom openDayEventsTemplate.
I think changelog is missing information about adding let-isOpen="isOpen" line to the ng-template tag of openDayEventsTemplate. I've spent half hour figuring out what's missing :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants