Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag&drop with scroll on mobile/pad Chrome #867

Closed
AstRonin opened this issue Jan 23, 2019 · 9 comments
Closed

drag&drop with scroll on mobile/pad Chrome #867

AstRonin opened this issue Jan 23, 2019 · 9 comments

Comments

@AstRonin
Copy link

AstRonin commented Jan 23, 2019

Describe the bug

Calendar type: day-view-scheduler
There does not work expectable Drag&Drop (up and down) with Scroll on mobile/pad Chrome. (About iPad/iPhone I don't know because I have not these).

  • On Demo and my site drag&drop works but scroll not works.
  • On my sample (look link below) drag&drop and scroll work both at one time.

Minimal reproduction of the problem with instructions

Please look to test page:
https://angular-lrkesj.stackblitz.io
And you can find on your demo site:
https://mattlewis92.github.io/angular-calendar/#/day-view-scheduler

Versions

  • "@angular/core": "6.1.9",
  • "angular-calendar": "^0.26.4",
  • Android 7.0
  • Chrome 71

Note

On this page
https://fullcalendar.io/releases/fullcalendar-scheduler/1.9.4/demos/vertical-resource-view.html
you can find how it should work: drag&drop activate after LongType on screen, before works scroll...
Do you use long type events https://fullcalendar.io/docs/touch?

@AstRonin
Copy link
Author

@AstRonin
Copy link
Author

I found something, if I remove (mwlClick) from mwl-calendar-day-view-hour-segment, then scroll works better
image

@mattlewis92
Copy link
Owner

The issue is caused by hammerjs adding these properties to all clickable elements:
screenshot 2019-02-03 at 11 28 52

If you use your own CSS to override them then it should fix the issue. Or if you remove hammerjs it will also fix it, but then you lose the responsiveness on click. I spent a long time fiddling about with this trying to find a solution to this issue that works out the box, but couldn't find anything. If you can work out a solution and could send a PR that would be amazing! 😄

@mattlewis92
Copy link
Owner

Looks like @wendlandreas found a solution here for anyone that's interested: #724 (comment)

@AstRonin
Copy link
Author

AstRonin commented Mar 12, 2019

I am not sure what understand how I can use it... Can you please put it to Day Schedule Example?

@mattlewis92
Copy link
Owner

Sure, I just added it to the demo. To use it

1/ Upgrade to the latest version of the calendar: npm i angular-calendar@0.26.9
2/ Add this to the providers of your root app module

I just tested it on chrome on ios and it's working pretty well now 😄

@fquirozjara
Copy link

Hi! @mattlewis92 thanks a lot for that fix, but i have some trouble when i try to use (press)="something()" on ios, all works fine until i use that press function and i lost scrolling again,

@mattlewis92
Copy link
Owner

Sorry I don't really do a lot of mobile development or use hammerjs myself, that solution was copied from another user

@AstRonin
Copy link
Author

AstRonin commented Apr 4, 2019

@fquirozjara For mobile platform I use Context Menu as temp and acceptable solution (I'm not implemented this fix yet for me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants