Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

feat: allow the use of publicKeyJwk to derive and verify proof #145

Merged
merged 1 commit into from
Aug 5, 2021
Merged

feat: allow the use of publicKeyJwk to derive and verify proof #145

merged 1 commit into from
Aug 5, 2021

Conversation

chiechelski
Copy link
Contributor

Description

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@chiechelski chiechelski requested a review from tplooker August 4, 2021 01:37
kdenhartog
kdenhartog approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I spotted could be an issue, but everything else looks fine to me.

@tplooker
Copy link
Member

tplooker commented Aug 4, 2021

@chiechelski any chance we could add some tests to cover this case?

tplooker
tplooker suggested changes Aug 4, 2021
View reviewed changes
Copy link
Member

@tplooker tplooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just based on my comments above

@chiechelski chiechelski force-pushed the gc/use-public-jwk branch 5 times, most recently from ef77fb3 to 11abb5d Compare August 5, 2021 03:50
kdenhartog
kdenhartog approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests look good now. Only thing we'll need to do is go back and update is the usage of unstable here

@chiechelski chiechelski requested a review from tplooker August 5, 2021 08:18
@chiechelski chiechelski force-pushed the gc/use-public-jwk branch 2 times, most recently from 9727ad1 to 63d2474 Compare August 5, 2021 09:08
@chiechelski chiechelski force-pushed the gc/use-public-jwk branch 14 times, most recently from e293c98 to 61b4ad5 Compare August 5, 2021 21:06
@chiechelski chiechelski force-pushed the gc/use-public-jwk branch 5 times, most recently from 60ea7af to 8a410b3 Compare August 5, 2021 21:23
@chiechelski chiechelski merged commit 0cec1f1 into master Aug 5, 2021
@tplooker tplooker deleted the gc/use-public-jwk branch August 5, 2021 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tplooker tplooker tplooker approved these changes

@kdenhartog kdenhartog kdenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiechelski @tplooker @kdenhartog