Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

feat: update to use bbs-signatures #73

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

tplooker
Copy link
Member

Description

Updates to use bbs signatures as the core dependency rather than node-bbs-signatures.

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

Allows support for using this library in more of the TS/JS ecosystem e.g the browser due to bbs-signatures being WASM based. Note bbs-signatures has an optional dependency on node-bbs-signatures

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@github-actions
Copy link

Total Coverage: 87.70%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   BbsBlsSignature2020.ts58.49%100%87.50%103, 112, 120, 125, 130, 134, 208, 209, 220, 221, 319, 320, 323, 324, 342, 343, 347, 348, 362, 363, 386, 47, 48, 51, 63, 68, 72, 75, 79, 80, 81, 81, 81, 82
   BbsBlsSignatureProof2020.ts62.96%81.25%85.15%166, 167, 176, 294, 295, 300, 336, 338, 342, 348, 379, 384, 396, 397, 399, 400, 418, 419, 423, 424, 43, 68, 69, 82, 91
   deriveProof.ts50%100%85.71%33, 34, 52, 81, 82
   index.ts100%100%100%
   utilities.ts70%100%96.67%119, 43, 79, 80

@tplooker tplooker merged commit 540ccec into master Aug 28, 2020
@tplooker tplooker deleted the tl/bbs-signatures-upgrade branch August 28, 2020 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant