This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: adds support for providing a proofDocument with multiple proofs #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Total Coverage: 87.84% Coverage Report
|
|||||||||||||||||||||||||||||||||||
|
@tplooker thoughts on best way to add samples here for it? Would you prefer to see it written in a separate file other than index.ts or add to the current sample to show deriving proof of single proofDocuments and multi proofDocuments. |
kdenhartog
force-pushed
the
kdh/issue-79
branch
from
c28b4b6 to
810d802
Compare
tplooker
reviewed
Oct 2, 2020
kdenhartog
force-pushed
the
kdh/issue-79
branch
3 times, most recently
from
862f763 to
5f4efc2
Compare
|
@tplooker all of the code is working correctly now with two proofs being properly derived. However, the changes to the samples won't work yet until we release the package and consume the new version. Because of this, I opted to move these into a separate PR (#83) which will be merged after the release is done. |
|
Total Coverage: 88.26% Coverage Report
|
|||||||||||||||||||||||||||||||||||
kdenhartog
force-pushed
the
kdh/issue-79
branch
from
5f4efc2 to
97c1f07
Compare
|
Total Coverage: 88.26% Coverage Report
|
|||||||||||||||||||||||||||||||||||
8 tasks
tplooker
reviewed
Oct 5, 2020
|
Total Coverage: 88.26% Coverage Report
|
|||||||||||||||||||||||||||||||||||
kdenhartog
force-pushed
the
kdh/issue-79
branch
2 times, most recently
from
d00f686 to
f402494
Compare
|
Total Coverage: 88.26% Coverage Report
|
|||||||||||||||||||||||||||||||||||
see issue #79 for details
kdenhartog
force-pushed
the
kdh/issue-79
branch
from
f402494 to
3c9ee02
Compare
|
Total Coverage: 88.26% Coverage Report
|
|||||||||||||||||||||||||||||||||||
tplooker
approved these changes
Oct 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #79 for additional details
Description
Motivation and Context
Does this PR introduce a breaking change?
Which merge strategy will you use?