Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

fix: update blsCreateProof expected response to promise #98

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

chiechelski
Copy link
Contributor

Description

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

When using rn-bbs-signature library this method will not work because it returns a promise.

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@github-actions
Copy link

Total Coverage: 88.64%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   BbsBlsSignature2020.ts58.49%100%87.63%102, 111, 119, 124, 129, 133, 207, 208, 219, 220, 318, 319, 322, 323, 341, 342, 346, 347, 361, 362, 385, 47, 48, 51, 62, 67, 71, 74, 78, 79, 80, 80, 80, 81
   BbsBlsSignatureProof2020.ts62.96%81.25%85.98%173, 174, 183, 300, 301, 306, 342, 344, 348, 354, 385, 390, 402, 403, 405, 406, 424, 425, 429, 430, 44, 69, 72, 87, 96
   deriveProof.ts83.33%100%90.91%123, 124, 33, 34, 83
   index.ts100%100%100%
   utilities.ts75%100%96.88%122, 43, 82, 83

@chiechelski chiechelski merged commit 2523b47 into master Jan 28, 2021
@tplooker tplooker deleted the gc/async-create-proof-method branch February 12, 2021 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants