Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for scoped oder module styling missing #21

Open
MDSLKTR opened this issue Mar 1, 2020 · 5 comments
Open

Support for scoped oder module styling missing #21

MDSLKTR opened this issue Mar 1, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@MDSLKTR
Copy link

MDSLKTR commented Mar 1, 2020

Hey,

first of all thank you for the project. Do you know if support for scoped styling in the style tag can be supported since this is what most of the components will have (at least in most projects i know of). The same goes for the "module" attribute resulting in css module hashes.

Regards,
Simon

@mattrothenberg
Copy link
Owner

mattrothenberg commented Mar 1, 2020

Howdy,

I don't know off the top of my head. Have you tried and had no success?

@MDSLKTR
Copy link
Author

MDSLKTR commented Mar 1, 2020

Hey, i tried both yet the data-attributes for scoped stylings are missing, same for the hashed classes. So the component will only be styled if <style> is plain.

@mattrothenberg
Copy link
Owner

Understood. I'm not spending much time in Vue these days, so feel free to take a stab at a PR.

This codebase is super small, so it should be fairly straightforward to see how it fits together.

@MDSLKTR
Copy link
Author

MDSLKTR commented Mar 1, 2020

Alright, thanks for the quick reply! Will see what i can do 👍

@mattrothenberg
Copy link
Owner

No problem, happy to provide feedback on a PR.

@mattrothenberg mattrothenberg added the enhancement New feature or request label Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants