Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to undo token deletion #275

Open
mattrubin opened this issue Apr 24, 2018 · 1 comment
Open

Add the ability to undo token deletion #275

mattrubin opened this issue Apr 24, 2018 · 1 comment

Comments

@mattrubin
Copy link
Owner

As suggested in a PR comment, the deletion confirmation alert could be replaced or augmented by the ability to undo deletion and restore a deleted token.

This feature would require underlying data model changes to store a "deleted" state for tokens. It's also worth considering whether the ability to restore a deleted token should be time-limited, and/or if there needs to be some way to permanently delete tokens, for security or privacy reasons.

@beaucollins
Copy link
Collaborator

beaucollins commented Sep 27, 2018

If you think about it there's really not a lot of upside to deleting the secret from the keychain. I guess you could say it's more secure than having lingering secrets but in the end losing a secret seems worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants