Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chrome variants in fetcher #244

Open
Sytten opened this issue Oct 23, 2024 · 1 comment
Open

Support chrome variants in fetcher #244

Sytten opened this issue Oct 23, 2024 · 1 comment

Comments

@Sytten
Copy link
Contributor

Sytten commented Oct 23, 2024

Since I last wrote the fetcher, chrome added new distributions for us to use instead of the good old chromium.
We can use chrome-driver, chrome-headless-shell and chrome. They are all available on https://googlechromelabs.github.io/chrome-for-testing/ (bucket https://storage.googleapis.com/chrome-for-testing-public).
This drastically reduces the maintenance burden of tracking which chromium revision has an actual build and also adds support for linux aarch64 (fixes #238).

I will work on it this november, it should be fairly easy to add.

@Sytten
Copy link
Contributor Author

Sytten commented Oct 24, 2024

Update after a couple hours, it looks like since puppeteer switched to chrome-for-testing the chromium builds are all over the place and finding revision that was available on all platforms is hard. They also shutdown the proxy that people were using to get the revisions (https://omahaproxy.appspot.com/all.json?channel=${channel}&os=linux)
Links for references:
-https://chromiumdash.appspot.com/commits
-https://github.com/puppeteer/puppeteer/blob/bc93722c244ded3c3c8d67fd40ad744f19e86ba7/tools/check_availability.js
-https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/
-https://source.chromium.org/chromium/chromium/src

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant