Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Refresh devices #46

Open
PhilipMay opened this issue Feb 24, 2023 · 1 comment
Open

Enhancement: Refresh devices #46

PhilipMay opened this issue Feb 24, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@PhilipMay
Copy link
Collaborator

The devices are only checked at startup. That means when one device is added or removed while the exporter is running - it will not detect this.

@ngosang
Copy link
Collaborator

ngosang commented Mar 18, 2023

They won't be detected. You have to restart the exporter.
The most common use case is to shutdown the server to add the devices, so, the exporter is restarted too.
If you have some use case with plug & play and you need to refresh the devices, you could open a PR but it will be accepted only if the "refresh devices" could be disabled with an environment variable.

@ngosang ngosang changed the title What happens when devices are added or removed? Enhancement: Refresh devices Mar 18, 2023
@ngosang ngosang added enhancement New feature or request help wanted Extra attention is needed labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants