Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About your implementation #2

Open
moonman925 opened this issue Dec 6, 2021 · 2 comments
Open

About your implementation #2

moonman925 opened this issue Dec 6, 2021 · 2 comments

Comments

@moonman925
Copy link

Hi, thx for sharing your codes, great works!
I have serval questions about the implementatation.

  1. according to the issue from the official hififace github repo, both masks are activated by sigmoid but I noticed that you used tanh.
  2. did you encounter with situation like, the mask learns a all-zero mask, which cause the model generate the exact same image as target image ?
@usingcolor
Copy link
Contributor

Hi! Thank you for your interest!

  1. Are you talking about this issue on the official project Github? Honestly, I didn’t know this existed. I decided on some details that were not mentioned on the paper, like activation for masks. I don't think this makes a very big difference during training.

  2. That shouldn't be happening. Segmentation loss is included in the loss function, which forces the mask to match the ground truth mask.

@pjh4993
Copy link

pjh4993 commented Dec 19, 2022

Hi, Thx for your works.

I also have some question about slight difference in your implementation.

  1. In paper, author use both face recogntion model's id and 3dMM's identity, expression, posture vector to construct V_id. However, I found that your implementation only use face recognition model's id. Does this difference was intended? I was also curious about what could go wrong when we drop that from V_id formulation
  2. How did you get dilated mask for SFF model's target? I couldn't found any specific guide to get target mask in both paper and Mask preprocessing provided in README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants