Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbox:versions -DapplyToPom=true defines a new property in BOM instead of updating parent project #154

Open
jakub-bochenski opened this issue Dec 18, 2024 · 5 comments

Comments

@jakub-bochenski
Copy link

See also mojohaus/versions#1200

I tried using toolbox as an alternative.
It's better in that it detects that the property should be upgraded.

But it defines a new property in child/BOM module instead of updating the property defined in parent module.

@cstamas
Copy link
Member

cstamas commented Dec 18, 2024

Yup, applyToPom is still limited, especially when a whole reactor is to be observed... is still marked as "experimental".

It works for simple use cases like having a parent POM that already follows "best practices" for now...

@jakub-bochenski
Copy link
Author

jakub-bochenski commented Dec 18, 2024

It works for simple use cases like having a parent POM that already follows "best practices" for now...

Care to elaborate what those best practices are? I thought my module structure already does follow best practices (There is a project attached to the versions issue)

@cstamas
Copy link
Member

cstamas commented Dec 20, 2024

@jakub-bochenski could you put your reproducer into a git repo? It would be much easier to show.... but on a related note:
apache/maven-site#598 (comment)

@jakub-bochenski
Copy link
Author

interesting, thanks!
so the gist of what I'm doing wrong seems to be:

In short: only external BOMs should be imported to reactor.

@cstamas
Copy link
Member

cstamas commented Dec 20, 2024

Yes, Maven4 already warns you if you import a BOM within a reactor, and later versions will probably fail the build even.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants