Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS horizontal accuracy #1020

Closed
pavloblindnology opened this issue May 2, 2018 · 3 comments
Closed

GPS horizontal accuracy #1020

pavloblindnology opened this issue May 2, 2018 · 3 comments

Comments

@pavloblindnology
Copy link

What is the reason of using HDOP value for computing horizontal accuracy of GPS_RAW_INT message instead of using h_acc values contained in the message? HDOP value is a scale factor, so, at least it should be multiplied by some metric accuracy estimation. Otherwise, it gives unrealistically small values.

fix->position_covariance[0 + 0] = fix->position_covariance[3 + 1] = std::pow(hdop, 2);

@vooon
Copy link
Member

vooon commented May 3, 2018

Just because that code done for a very long time before GPS_RAW_INT have extended with that fields.
And note, extension do not work with mavlink v1.0.

@pavloblindnology
Copy link
Author

Understood.
Can we use extension values if on mavlink v2.0 and HDOP otherwise?
Also, I'd add some metric accuracy estimation parameter to config file to be scaled by HDOP, VDOP.
Is it feasible?

@TSC21
Copy link
Member

TSC21 commented May 4, 2018

Understood.
Can we use extension values if on mavlink v2.0 and HDOP otherwise?
Also, I'd add some metric accuracy estimation parameter to config file to be scaled by HDOP, VDOP.
Is it feasible?

@pavloblindnology that seems reasonable to me. Can you please do a PR with it? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants