Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base_link and base_link_frd are hardcoded - Better to define them using parameters #1907

Closed
mzahana opened this issue Oct 11, 2023 · 2 comments
Labels
Milestone

Comments

@mzahana
Copy link
Contributor

mzahana commented Oct 11, 2023

Issue details

Can we make the base_link frame_id a parameter instead of having it fixed in this static transform ?

The odom.cpp plugin looks up a transform with respect to thebase_link_frd here

The issues is, when doing multi vehicle simulation, all the vehicles will have the same base_link and base_link_frd with the current implementation. However, they should be unique for each vehicle to have a proper TF tree. That is why I propose to make the base_link a parameter. Then, the FRD frame can be defined by adding _frd post-fix, so it becomes base_link_frame_id+"_frd".

I don't know where to define this parameter so I can propose a PR.

@vooon can you please check?
Thank you.

MAVROS version and platform

Mavros: 2.6.0
ROS: humble
Ubuntu: 22.04

Autopilot type and version

[ ] ArduPilot
[ x ] PX4

Version: 1.14

@mzahana
Copy link
Contributor Author

mzahana commented Oct 12, 2023

@vooon here is my PR #1909 to solve this issue.

@vooon vooon added this to the Version 2.7 milestone Oct 16, 2023
@vooon vooon added the ros2 label Oct 16, 2023
@vooon
Copy link
Member

vooon commented Oct 16, 2023

Should be fixed now.

@vooon vooon closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants