fix: fatal error: only variables can be passed by reference, close #31

searchfe · May 5, 2019 · 0fbb69b · 0fbb69b
1 parent 714c418
commit 0fbb69b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/emitter.ts b/src/emitter.ts
@@ -732,9 +732,10 @@ export function emitFile(
         // emitModifiers(node, node.modifiers);
         // emit(node.dotDotDotToken);
 
-        if (node.parent && node.parent.kind === SyntaxKind.FunctionDeclaration) {
+        if (node.parent && [SyntaxKind.FunctionDeclaration, SyntaxKind.MethodDeclaration].includes(node.parent.kind)) {
             const type = typeChecker.getTypeAtLocation(node.name);
-            if (type && type.flags === ts.TypeFlags.Object) {
+            const symbol = type.getSymbol();
+            if (type && type.flags === ts.TypeFlags.Object && symbol && !symbol.members.has('__call' as ts.__String)) {
                 write('&');
             }
         }

diff --git a/test/features/funcParamRefer.php b/test/features/funcParamRefer.php
@@ -5,7 +5,7 @@
     "a" => 1
 );
 $c = "123";
-function aaa(&$m, &$n, $k) {
+function aaa(&$m, &$n, $k, $d) {
     array_push($m, 4);
     $n["b"] = 2;
     $k .= "4";

diff --git a/test/features/funcParamRefer.ts b/test/features/funcParamRefer.ts
@@ -4,7 +4,7 @@ let b = {
 };
 let c = '123';
 
-function aaa(m: number[], n: {[name: string]: number}, k: string) {
+function aaa(m: number[], n: {[name: string]: number}, k: string, d?: () => string) {
     m.push(4);
     n.b = 2;
     k += '4';