feat: support x === undefined & x !== undefined

searchfe · Jun 4, 2019 · f5d71ae · f5d71ae
1 parent 457236f
commit f5d71ae
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 2 deletions.
diff --git a/src/features/global.ts b/src/features/global.ts
@@ -7,7 +7,11 @@ import {
     EmitHint,
     isCallExpression,
     isPropertyAccessExpression,
-    isIdentifier
+    isIdentifier,
+    isBinaryExpression,
+    SyntaxKind,
+    createCall,
+    createIdentifier
 } from 'typescript';
 
 import method from '../utilities/method';
@@ -59,6 +63,23 @@ export default {
             }
         }
 
+        if (
+            isBinaryExpression(node)
+            && node.operatorToken.kind === SyntaxKind.EqualsEqualsEqualsToken
+            && node.right.originalKeywordKind === SyntaxKind.UndefinedKeyword
+        ) {
+            helpers.writePunctuation('!');
+            return helpers.emitExpression(createCall(createIdentifier('isset'), [], [node.left]));
+        }
+
+        if (
+            isBinaryExpression(node)
+            && node.operatorToken.kind === SyntaxKind.ExclamationEqualsEqualsToken
+            && node.right.originalKeywordKind === SyntaxKind.UndefinedKeyword
+        ) {
+            return helpers.emitExpression(createCall(createIdentifier('isset'), [], [node.left]));
+        }
+
         return false;
     }
 };
diff --git a/src/utilities/nodeTest.ts b/src/utilities/nodeTest.ts
@@ -184,4 +184,4 @@ export function isVisibilityModifier(node: ts.Modifier) {
 
 export function isSupportedPropertyModifier(node: ts.Modifier) {
     return isVisibilityModifier(node) || node.kind === SyntaxKind.StaticKeyword;
-}
+}
diff --git a/test/features/isset.php b/test/features/isset.php
@@ -0,0 +1,9 @@
+<?php
+namespace test\case_isset;
+$a = 1;
+if (!isset($a)) {
+    echo "a";
+}
+if (isset($a)) {
+    echo "a";
+}
diff --git a/test/features/isset.ts b/test/features/isset.ts
@@ -0,0 +1,9 @@
+const a = 1;
+
+if (a === undefined) {
+    console.log('a');
+}
+
+if (a !== undefined) {
+    console.log('a');
+}
diff --git a/typescript.d.ts b/typescript.d.ts
@@ -1148,6 +1148,7 @@ declare namespace ts {
     type StringLiteralLike = StringLiteral | NoSubstitutionTemplateLiteral;
     interface Expression extends Node {
         _expressionBrand: any;
+        originalKeywordKind?: SyntaxKind
     }
     interface OmittedExpression extends Expression {
         kind: SyntaxKind.OmittedExpression;
-Original file line number
+Diff line change
@@ Expand Up / @@ -184,4 +184,4 @@ export function isVisibilityModifier(node: ts.Modifier) { @@
     export function isSupportedPropertyModifier(node: ts.Modifier) {
         return isVisibilityModifier(node) || node.kind === SyntaxKind.StaticKeyword;
-    }
+    }