time features by default

[1g0rkR]

Hi there,

Would be possible to have a choice between time and chrono of sqlx?

I would appreciate for such opportunities.

[1g0rkR]

It conflicts with originally sqlx/chrono in my code.

[maxcountryman]

If you would like to make a PR that enables either choice, I'm happy to review.

[vinnymeller]

@1g0rkR I dont love how I implemented it but my fork here is working with chrono: https://github.com/vinnymeller/tower-sessions-sqlx-store

as stated in the readme I do not recommend at all using it - but you can at a minimum you can see which part(s) of the code need to be updated to support chrono

edit: if nobody has gotten to it i will look to make the changes neater & make a pr in a few weeks when I'm back from vacation

[karuna]

maybe something like this? #46
for me it's becoming critical because of sqlx < 0.8.1 security problem

[karuna]

mostly from @vinnymeller

[maxcountryman]

for me it's becoming critical because of sqlx < 0.8.1 security problem

This is why SessionStore is a public trait. You can and should implement stores to suit your specific use cases and needs.

[dns2utf8-novaziun]

Is there a way to disable time somehow? Because it causes a circular break with sqlx right now

[dns2utf8-novaziun]

I found the PR #46 that was reverted in this commit 3a546a9
I don't understand why, because it just re-broke any setup with sqlx > 0.8.x

[nicolasauler]

Yeah, is there a recommended solution?
I'm also stuck because I need to update sqlx, but this crate then causes time feature dependency to be activated in sqlx

edit: actually, I reminded that I didn't actually care about chrono and migrated my app from chrono to time, no biggie

[dns2utf8-novaziun]

I migrated my ${Something}Row structs to the time crate and made two functions that convert back and forth between chrono and time.
This is not great but was the pragmatic path out of the stuck situation while not having to rewrite all of my business logic

[maxcountryman]

Probably the feature selection can be removed entirely and replaced with something like this: https://github.com/maxcountryman/underway/blob/40f8f899587cb0125e2b8897a4349d2f9c0a391d/src/timestamp.rs which then is used in the crate here as a type override (note that this is particularly ugly in the linked example, but in practice could be cleaned up). Doing so allows e.g. https://github.com/maxcountryman/underway/blob/40f8f899587cb0125e2b8897a4349d2f9c0a391d/Cargo.toml#L15-L19.