Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 AutoObject _insert_rows method broken #230

Open
ollyhensby opened this issue Nov 22, 2023 · 1 comment
Open

🐛 AutoObject _insert_rows method broken #230

ollyhensby opened this issue Nov 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ollyhensby
Copy link
Contributor

ollyhensby commented Nov 22, 2023 •
edited
Loading

Describe the bug
_insert_rows method broken in AutoObject

I think this is because the rows attribute has been deprecated from the class.

Expected behavior
Expect to be able to inject UI components using this method. Or shall we deprecate this method?
@ollyhensby ollyhensby added the bug Something isn't working label Nov 22, 2023
@ollyhensby ollyhensby changed the title 🐛 🐛 _insert_rows method broken Nov 22, 2023
@ollyhensby ollyhensby changed the title 🐛 _insert_rows method broken 🐛 AutoObject _insert_rows method broken Nov 22, 2023
@jgunstone
Copy link
Collaborator

good spot -
i think at some point a var name changed...
now need to use di_boxes

ipyautoui/src/ipyautoui/autoobject.py

Line 353 in 877a537

self.vbx_main.children = list(self.di_boxes.values())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgunstone @ollyhensby