Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Remove font-awesome #598

Open
barryvdh opened this issue Feb 14, 2024 · 3 comments
Open

[Request] Remove font-awesome #598

barryvdh opened this issue Feb 14, 2024 · 3 comments

Comments

@barryvdh
Copy link
Collaborator

Based on #272
Can we just use https://tabler.io/icons icons as svg inline? Either add the default ones to css, or allow the collectors to define svg (base64 encoded or something?)

@parallels999
Copy link
Contributor

Seems like a big change, possibly a breaking change, a lot of icons, and dependencies use custom Indicators with fa icons, they would lose the icons

@barryvdh
Copy link
Collaborator Author

Yeah might warrant a 2.x version.

@miken32
Copy link

miken32 commented Jul 8, 2024

As additional motivation for removing this, I'm seeing this notice popping up repeatedly on my console lately. Fixed in FA 6.5, but a very old version is bundled in to this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants