Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write better tests #5

Open
maxkueng opened this issue Nov 9, 2013 · 2 comments
Open

Write better tests #5

maxkueng opened this issue Nov 9, 2013 · 2 comments

Comments

@maxkueng
Copy link
Owner

maxkueng commented Nov 9, 2013

Test more stuff more extensively
@maxkueng maxkueng mentioned this issue Nov 9, 2013
Merged
@jbraithwaite
Copy link

Hey Max,

Tests are timing out, maybe consider using Sinon (or something similar) to fake http requests?

@maxkueng
Copy link
Owner Author

Thanks @jbraithwaite! I know... I even already give mocha 10 seconds for each test and they still time out.
But yes, it's not the idea to test MusicBrainz's endpoint too. I just currently don't have time to make it better. Thanks for the tip about Sinon. I'll check it out. I had previously stumbled upon echoecho. I'll have a look at both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxkueng @jbraithwaite