updated UserTable.tsx to not include duplicate usernames, including n… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames with different case. Fixes maxonary#20
👷 Deploy request for endearing-empanada-f1c86d pending review.Visit the deploys page to approve it
|
|
Someone is attempting to deploy a commit to a Personal Account owned by @maxonary on Vercel. @maxonary first needs to authorize it. |
|
Hey Geoff, thanks for contributing! It's a neat fix, but this results in the usernames of the other game types not being shown. As a username can be entered "twice", once per game type (once for Java Edition and once for Bedrock Edition), you should also compare the game type to prevent hiding entries. The current code results in this misbehaviour: Bildschirmaufnahme.2023-09-24.um.14.48.36.movI think issue #20 lies already in the server accepting case-sensitive usernames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ames with different case. Fixes #20
This pull request adds a feature to the
UserTablecomponent that prevents duplicate usernames from being added to the table. The component now uses aSetdata structure to keep track of usernames that have already been added to the table. If a user with a duplicate username is encountered, the component skips adding the user to the table.Changes Made
usernamesSet to keep track of usernames that have already been added to the table