-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Infinity percentage. #1241
Comments
@CarlosLugones that metric is comparing against the prior month, which was 0%. An increase from 0 -> 0.33 would be an infinite increase, so I think this is expected behavior. Once you have several months of data, you'll see a more meaningful metric here. |
Infinity feels weird when speaking about money. I think that is confusing, but if you say that this is the expected behavior, okay. As a user, I found it confusing. @zachgoll |
@CarlosLugones what would you display instead? I'm happy to change it if we can come up with a more intuitive value to put here. I just haven't been able to think of anything myself. |
My recommendation would be to remove this, until you can showcase something. If there is no previous month, don't show the "Infinity", neither "vs. last month". It would be: I just asked a frontend expert and that was his recommendation also. |
Other option is explicitly call out the missing data - "No data to compare from September" for instance. |
@CarlosLugones makes sense to me, I think that's a reasonable solution. @justinfar would you agree with showing nothing if infinity? @jamie I think that option ends up getting a bit messy given our limited space here, but could work in other parts of the app. |
Voting for not showing anything. Let the user discover this after 1 month. |
Describe the bug
Income, saving rate, and spending shows a "infinite" percentage, compared to previous month.
I just started using Maybe in the Umbrel OS, and maybe because there is no previous month, that's causing this bug.
To Reproduce
Expected behavior
Showing the real percentage, or none.
Screenshots / Recordings
The text was updated successfully, but these errors were encountered: