Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Infinity percentage. #1241

Closed
CarlosLugones opened this issue Oct 4, 2024 · 7 comments · Fixed by #1261
Closed

Bug: Infinity percentage. #1241

CarlosLugones opened this issue Oct 4, 2024 · 7 comments · Fixed by #1261

Comments

@CarlosLugones
Copy link

Describe the bug

Income, saving rate, and spending shows a "infinite" percentage, compared to previous month.

I just started using Maybe in the Umbrel OS, and maybe because there is no previous month, that's causing this bug.

To Reproduce

  1. Start from 0 with a new Maybe instance.
  2. Add some account.
  3. Add a few transactions.
  4. You will see "infinite%" up or down in the dashboard metrics.

Expected behavior

Showing the real percentage, or none.

Screenshots / Recordings

image

image

@zachgoll
Copy link
Collaborator

zachgoll commented Oct 4, 2024

@CarlosLugones that metric is comparing against the prior month, which was 0%.

An increase from 0 -> 0.33 would be an infinite increase, so I think this is expected behavior. Once you have several months of data, you'll see a more meaningful metric here.

@CarlosLugones
Copy link
Author

Infinity feels weird when speaking about money. I think that is confusing, but if you say that this is the expected behavior, okay. As a user, I found it confusing. @zachgoll

@zachgoll
Copy link
Collaborator

zachgoll commented Oct 4, 2024

@CarlosLugones what would you display instead? I'm happy to change it if we can come up with a more intuitive value to put here. I just haven't been able to think of anything myself.

@CarlosLugones
Copy link
Author

My recommendation would be to remove this, until you can showcase something.

If there is no previous month, don't show the "Infinity", neither "vs. last month".

It would be:
+0.33

I just asked a frontend expert and that was his recommendation also.

@jamie
Copy link

jamie commented Oct 4, 2024

Other option is explicitly call out the missing data - "No data to compare from September" for instance.

@zachgoll
Copy link
Collaborator

zachgoll commented Oct 4, 2024

@CarlosLugones makes sense to me, I think that's a reasonable solution. @justinfar would you agree with showing nothing if infinity?

@jamie I think that option ends up getting a bit messy given our limited space here, but could work in other parts of the app.

@CarlosLugones
Copy link
Author

Voting for not showing anything. Let the user discover this after 1 month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants