Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When balance and transaction exist on same day, balances not correctly calculated #1418

Closed
zachgoll opened this issue Nov 5, 2024 · 4 comments · Fixed by #1435 or #1483
Closed
Labels
🐛 Bug Something isn't working

Comments

@zachgoll
Copy link
Collaborator

zachgoll commented Nov 5, 2024

Describe the bug
A clear and concise description of what the bug is.

There are two things worth fixing here:

  1. The balance calculation should result in $100
  2. The "balance update" should be based on the trend vs. previous balance ($100), and should be downward. Currently, it is an "upward" trend because we're comparing it against the previous known balance of $0.

CleanShot 2024-11-05 at 10 35 26

@zachgoll zachgoll added the 🐛 Bug Something isn't working label Nov 5, 2024
@mikr13
Copy link

mikr13 commented Nov 8, 2024

Also why do we have to do a balance update manually? Shouldn't balance be calculated based on transactions/incomes in a day?

@nicogaldamez
Copy link
Contributor

@mikr13 it might come in handy if you’re dealing with a lot of transactions and don’t mind if some are missing or if you made a mistake along the way. You know the balance but don’t have all the transaction details, so you can just update the balance manually

@Shpigford
Copy link
Member

Also why do we have to do a balance update manually? Shouldn't balance be calculated based on transactions/incomes in a day?

There are many use cases when doing manual entry. Frequently folks don't want to enter transaction data, they just want to update the balance of various accounts.

@mikr13
Copy link

mikr13 commented Nov 8, 2024

Yeah, that's fair. But what I noticed is that the transactions marked as expenses don't decrease the total balance in that account. Only when balance update is done then the account's balance changes.

Nvm, it was a bug or something. Transactions are properly updating balance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
4 participants