Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: pie chart on dashboard does not support multi-currency formatting #842

Closed
2 tasks done
AurelienConte opened this issue Jun 7, 2024 · 4 comments · Fixed by #1022
Closed
2 tasks done

Bug: pie chart on dashboard does not support multi-currency formatting #842

AurelienConte opened this issue Jun 7, 2024 · 4 comments · Fixed by #1022
Assignees
Labels
🐛 Bug Something isn't working

Comments

@AurelienConte
Copy link

AurelienConte commented Jun 7, 2024

Where did this bug occur?

  • Local development
  • Self hosted app (i.e. Docker)

Describe the bug

On the dashboard after adding my first checking account the assets graph is showing my checking account value with an "undefined" value.

To Reproduce

  • Follow the self hosted docker installation and open the dashboard.
  • Create your first account
  • Add a bank account with a positive amount
  • Refresh the dashboard
  • You should see undefined in the upper right part of the dashboard ( Above total assets )

Expected behavior

I expect to show my account value but without the undefined keyword

Screenshots / Recordings

image

@AurelienConte AurelienConte added the 🐛 Bug Something isn't working label Jun 7, 2024
@AurelienConte
Copy link
Author

AurelienConte commented Jun 7, 2024

By the way i'm looking for some "Good first issue" to start working on the project and i think this can be a good one !

EDIT : If i look to the pie_chart_controller.js it seems that the fractionalPart is undefined in my case but displayed in any case instead of displayed only when not undefined.

@zachgoll
Copy link
Collaborator

zachgoll commented Jun 7, 2024

@AurelienConte yeah this would be a great first issue, you're welcome to take it!

@AurelienConte
Copy link
Author

Okay !
Thanks i take it !

@AurelienConte
Copy link
Author

I created a PR about this #844

@zachgoll zachgoll changed the title Bug: "undefined" value on dashboard assets graph Bug: pie chart on dashboard does not support multi-currency formatting Jun 10, 2024
@zachgoll zachgoll self-assigned this Jul 25, 2024
@zachgoll zachgoll linked a pull request Jul 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants