Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code improvements noticed during PR review #19

Open
5 of 6 tasks
sergei-maertens opened this issue Oct 27, 2022 · 0 comments
Open
5 of 6 tasks

Code improvements noticed during PR review #19

sergei-maertens opened this issue Oct 27, 2022 · 0 comments
Milestone

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Oct 27, 2022

This mostly comes from #16 which has turned into a massive PR, so we're splitting out the non-criticals here:

  • Update the documentation - notably the settings have been removed (Project cleanup #20)
  • Refactor fully-qualified URL building - there's mixed furl usage and string concatenation happening now which isn't particularly elegant
  • Add to the documentation that the reverse proxy headers (:func:get_client_ip) need to be sanitized/trusted for client IP detection
  • remove the requirements/base.txt and put all the requirements into setup.cfg metadata (pip install -e . needs to pull everything in) (Project cleanup #20)
  • eherkenning requestedAuthnContext is now an ugly magic number list index - this should be fetched from config model
  • convert tests to pytest style and replace mixins with pytest fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant